Skip to content

remove ament_export_link_flags() for atomic operations. #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fujitatomoya wants to merge 1 commit into
base: rolling
Choose a base branch
from
Draft

remove ament_export_link_flags() for atomic operations. #528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,10 @@ target_link_libraries(${PROJECT_NAME} ${CMAKE_DL_LIBS})
check_library_exists(atomic __atomic_load_8 "" HAVE_LIBATOMICS)

if(HAVE_LIBATOMICS AND NOT WIN32)
# Exporting link flag since it won't pass ament_export_libraries() existence check
ament_export_link_flags("-latomic")
# Link libatomic into rcutils for fault injection atomic operations.
# Don't export it - downstream packages get atomic symbols transitively
# through librcutils.so, avoiding library resolution issues in containerized
# environments. See https://github.com/ros2/rcutils/issues/525
target_link_libraries(${PROJECT_NAME} atomic)
endif()

Expand Down