Skip to content

Add mechanism to disable workaround for dependency groups#229

Merged
cottsay merged 1 commit intorollingfrom
cottsay/groups-workaround
Jun 5, 2024
Merged

Add mechanism to disable workaround for dependency groups#229
cottsay merged 1 commit intorollingfrom
cottsay/groups-workaround

Conversation

@cottsay
Copy link
Member

@cottsay cottsay commented Apr 24, 2024

See ros-infrastructure/catkin_pkg#369

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay merged commit ad9fca4 into rolling Jun 5, 2024
@cottsay cottsay deleted the cottsay/groups-workaround branch June 5, 2024 18:54
@emersonknapp
Copy link
Contributor

Is this all right to backport to Jazzy & Humble?
Here is me trying it, but I'm not sure if there are some considerations i might be missing

@Mergifyio backport jazzy humble

@cottsay
Copy link
Member Author

cottsay commented Sep 30, 2025

There isn't a particularly great reason to backport this. We still aren't fully utilizing it in any of our tooling, so this has only been used for experiments thus far. That said, I don't see any harm in backporting it either.

@emersonknapp
Copy link
Contributor

In all my CIs over the last few years I've had to add really explicit rosdep skip-keys for all the variations on Connext, rmw_connext, etc. But if instead I have this in the package.xml, I can set the environment variable and am good to go. Largely because we are building rmw_implementation from source on a fork https://github.com/robograph-project/rmw_implementation that I'm trying to keep as minimally different as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants