Conditional deserialization of message for ros2 topic hz
#1005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter` argument is provided. Signed-off-by: Kostubh Khandelwal <khandelwalkostubh@gmail.com>
fujitatomoya
approved these changes
Apr 9, 2025
Collaborator
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with green CI.
Collaborator
|
@exMachina316 thank you very much for taking care of this 👍 |
Collaborator
|
Pulls: #1005
|
Collaborator
|
IMO, this enhancement would be nice to backport to humble and jazzy. |
Member
|
I wonder how this affects/improves performance, especially for #843. |
Signed-off-by: Kostubh Khandelwal <khandelwalkostubh@gmail.com>
Member
|
I retriggered the same ci_launcher job:
|
Member
|
@ros-pull-request-builder retest this please |
christophebedard
approved these changes
Apr 9, 2025
Member
|
@Mergifyio backport jazzy humble |
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 9, 2025
Signed-off-by: Kostubh Khandelwal <khandelwalkostubh@gmail.com> (cherry picked from commit bfc5245) # Conflicts: # ros2topic/ros2topic/verb/hz.py
mergify bot
pushed a commit
that referenced
this pull request
Apr 9, 2025
Signed-off-by: Kostubh Khandelwal <khandelwalkostubh@gmail.com> (cherry picked from commit bfc5245) # Conflicts: # ros2topic/ros2topic/verb/hz.py
christophebedard
added a commit
that referenced
this pull request
Apr 9, 2025
…1005) (#1006) Signed-off-by: Kostubh Khandelwal <khandelwalkostubh@gmail.com> (cherry picked from commit bfc5245) Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com> Co-authored-by: Kostubh Khandelwal <123073764+exMachina316@users.noreply.github.com> Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
christophebedard
added a commit
that referenced
this pull request
Apr 9, 2025
…1005) (#1007) Signed-off-by: Kostubh Khandelwal <khandelwalkostubh@gmail.com> (cherry picked from commit bfc5245) Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com> Co-authored-by: Kostubh Khandelwal <123073764+exMachina316@users.noreply.github.com> Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #983
Added a conditional statement to set the
rawflag when creating subscriptions for topics based on the value offilter_expr. If the--filterflag is used,filter_expris not None and deserializing subscriptions are created. Otherwisefilter_expris None and 'raw' subscriptions are created.As for the
bwverb, it already uses 'raw' subscriptions and there is no case where desrialization of topics is required. Hence no changes made there.Manual Testing
$ ros2 topic hz /topic average rate: 2.002 min: 0.500s max: 0.500s std dev: 0.00000s window: 1 average rate: 2.000 min: 0.499s max: 0.501s std dev: 0.00105s window: 3 average rate: 2.000 min: 0.499s max: 0.501s std dev: 0.00084s window: 5$ ros2 topic hz /topic --filter 'int(m.data.rpartition(\"! \")[-1]) % 2 == 0' average rate: 1.000 min: 1.000s max: 1.000s std dev: 0.00000s window: 1 average rate: 1.000 min: 0.999s max: 1.000s std dev: 0.00024s window: 2 average rate: 1.000 min: 0.999s max: 1.001s std dev: 0.00065s window: 3