Fix Windows cursor installation by rebuilding with clickgen ≥ 2.2.0#15
Fix Windows cursor installation by rebuilding with clickgen ≥ 2.2.0#15tessapower wants to merge 5 commits intorose-pine:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes Windows cursor installation issues caused by bugs in older versions of clickgen by rebuilding the cursor themes with clickgen ≥ 2.2.0. It also renames references from "Rosé Pine" to "Rose Pine" to address cross-platform rendering issues with accented characters, and introduces automated build and release management via GitHub Actions.
Changes:
- Updates clickgen requirement to ≥ 2.2.0 via new
requirements.txtfile - Modifies Windows cursor names in
build.toml(shortens names like "Diagonal_1" → "Dgn1", "IBeam" → "Text", etc.) - Regenerates all bitmap cursor files for both RosePine and RosePineDawn themes with the updated tooling
- Updates
README.mdbuild instructions to referencerequirements.txtand renames references from "Rosé Pine" to "Rose Pine" in the build commands - Adds GitHub Actions workflow (
.github/workflows/build.yml) that automatically builds releases on main branch pushes and creates GitHub releases when version tags are pushed
Reviewed changes
Copilot reviewed 3 out of 170 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
requirements.txt |
Specifies clickgen ≥ 2.2.0 dependency |
build.toml |
Updates Windows cursor name mappings to shorter forms |
bitmaps/BreezeX-RosePine/*.png |
Regenerated cursor bitmap files |
bitmaps/BreezeX-RosePineDawn/*.png |
Regenerated cursor bitmap files |
README.md |
Updates build instructions and renames "Rosé Pine" to "Rose Pine" in build commands |
.github/workflows/build.yml |
Adds automated build and release workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| bunx cbmp -d 'svg' -n 'BreezeX-RosePine' -bc '#191724' -oc '#e0def4' | ||
| bunx cbmp -d 'svg' -n 'BreezeX-RosePineDawn' -bc '#faf4ed' -oc '#575279' |
There was a problem hiding this comment.
The PR description mentions renaming from "Rosé Pine" to "Rose Pine" for cross-platform compatibility, but the README still contains "Rosé Pine" references in earlier sections (lines 23, 24, 30, 31, 33, 34, 42, 43, 51, 52). While these lines aren't modified in this PR, this creates an inconsistency. Consider updating all references to "Rosé Pine" to "Rose Pine" throughout the README for consistency with the stated goal of fixing accented character rendering issues.
|
|
||
| on: | ||
| push: | ||
| branches: [main] |
There was a problem hiding this comment.
The workflow triggers on pushes to tags matching "v*" pattern AND on pushes to main branch, but the release job only runs on tag pushes. This means every push to main will run the build job (which is fine for validation), but be aware this will consume GitHub Actions minutes. Consider if you want to optimize this by also adding paths-ignore for the build job or only running full builds on tags and PRs.
| branches: [main] |
Merging this PR will:
install.inffile generated with an old version ofclickgenthat had two bugs which have since been fixed inclickgenv2.2.0.:mainand on tag pushes. To publish a release, push a tag in the formatv*(e.g.v1.0.0) and the workflow will create a GitHub release with all four archives attached.Tested by:
Fixes #6.