Skip to content
This repository was archived by the owner on Nov 9, 2022. It is now read-only.

Conversation

@adamantivm
Copy link
Contributor

@stonier could you please check this? Especially:

  • am I missing anything?
  • is it OK to overwrite this old readme content for now?

@stonier
Copy link
Contributor

stonier commented Dec 15, 2016

is it OK to overwrite this old readme content for now?

Probably worthwhile documenting what this package actually does for a dev here (i.e. not the user's usage info - that can definitely migrate) so it is easy to see at a glance what you can hack on inside.

  • catkin environment hooks to define/initialise variables that support and customise the build
  • cmake macro chain that implements the user's catkin_rosjava_setup() call
  • catkin_create_xxx scripts and supporting utilities

@adamantivm
Copy link
Contributor Author

@stonier in order to accelerate the release, what do you think about pushing that task to an issue in the repo (with a kinetic-update tag) to be done after a first release pass?
Then I can merge this as is and move on, and add that doc you suggest, cleaned-up, on a separate pass.
In order to avoid losing the old readme content permanently, I can add a link to the old readme content in the issue.
We could follow this procedure in general with other such tasks as well. What do you think?

@stonier
Copy link
Contributor

stonier commented Dec 15, 2016

in order to accelerate the release, what do you think about pushing that task to an issue in the repo (with a kinetic-update tag) to be done after a first release pass?

+1

Feel free to merge.

@adamantivm
Copy link
Contributor Author

ok, created #27 to track that.

@adamantivm adamantivm merged commit 662c622 into rosjava:kinetic Dec 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants