Conversation
oda
reviewed
May 23, 2024
| } | ||
| int index = Collections.binarySearch(increasingNums, nums[i]); | ||
| if (index < 0) { | ||
| increasingNums.set(-index-1, nums[i]); |
Owner
Author
There was a problem hiding this comment.
はい。bit演算普段あまりみないので、このままにしました。
|
特に違和感はなく、読みやすかったです。 |
| // Time spend: 04:20 | ||
| class Solution { | ||
| public int lengthOfLIS(int[] nums) { | ||
| List<Integer> increasingNums = new ArrayList<>(); |
There was a problem hiding this comment.
Suggested change
| List<Integer> increasingNums = new ArrayList<>(); | |
| var increasingNums = new ArrayList<Integer>(); |
長らく触ってないのでJavaの常識があまりわからないのですが、varを使った方がわかりやすい気がしました。しかしArrayListまで絞らずListにしておいた方が良いという考え方もありそうですね。
Owner
Author
There was a problem hiding this comment.
実際に業務で使ってる人に質問になるのですが、業務で型推論は推奨になっていますか？
(個人的には型推論利用したい派はあるが、諸事情で使っていません)
There was a problem hiding this comment.
Owner
Author
There was a problem hiding this comment.
なるほど、右側だけで型が明確である場合、varの方が好ましいのよくわかります。
今回の場合、Listインタフェースを利用したいというのがあって、明示的に書くしかなさそうです。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.