Conversation
oda
reviewed
Jul 29, 2024
| // Time spend: 04:32 | ||
| func maxProfit(prices []int) int { | ||
| buy := -prices[0]; | ||
| sell := buy + prices[0]; |
oda
reviewed
Jul 29, 2024
| // Space complexity: 1 | ||
| // Time spend: 04:32 | ||
| func maxProfit(prices []int) int { | ||
| buy := -prices[0]; |
There was a problem hiding this comment.
これ、負の値を入れたのが、min を定義するのが億劫という理由だけのように見えていますが、なにか理由ございますでしょうか。
There was a problem hiding this comment.
購入価格を負の数で表すのはなるほどとなりました！
個人的には正の数で表して、利益は引き算で計算するやり方が直感的でした。
erutako
reviewed
Aug 25, 2024
| // Space complexity: 1 | ||
| // Time spend: 04:32 | ||
| func maxProfit(prices []int) int { | ||
| buy := -prices[0]; |
There was a problem hiding this comment.
購入価格を負の数で表すのはなるほどとなりました！
個人的には正の数で表して、利益は引き算で計算するやり方が直感的でした。
| return sell | ||
| } | ||
|
|
||
| func max(a, b int) int { |
There was a problem hiding this comment.
Go全然知らないのですが現在は組み込み関数のmaxがあるようです？
https://future-architect.github.io/articles/20230815a/
Comment on lines
+8
to
+9
| buy = max(buy, -p) | ||
| sell = max(sell, buy + p) |
There was a problem hiding this comment.
buy, sellがそれぞれ最小購入価格、最大売却価格の意味を持つことを変数名で表すとわかりやすいかと思いました。
minBuyingPrice, maxSellingPrice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/best-time-to-buy-and-sell-stock/description/