Open
Conversation
oda
reviewed
Jul 29, 2024
| @@ -0,0 +1,19 @@ | |||
| ```java | |||
| return res; | ||
| } | ||
|
|
||
| private void backtrack(List<List<Integer>> res, List<Integer> tempList, int[] nums, int start) { |
There was a problem hiding this comment.
tempList が気になってしまいました。
backtrack() を呼ぶごとに1つの組み合わせとして res に add() しているので、subset とかでもいいかもしれません。
と、すみません backtrack() も気になりました。
makeSubsets() とか、何かしら付けるといいかもしれません。
fhiyo
reviewed
Jul 31, 2024
fhiyo
left a comment
fhiyo
left a comment
There was a problem hiding this comment.
いいと思います。別解がもう少しあるといいかもしれません。
あとstep3で変化がない場合は1つにまとめる方がレビュワー (や後でご自身が読み返すとき) の負担が減りそうです。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/subsets/description/