Conversation
nittoco
reviewed
Jul 29, 2024
| continue | ||
| } | ||
|
|
||
| dp[y][x] = dp[y - 1][x] + dp[y][x - 1] |
There was a problem hiding this comment.
ちょっとgoの命名習慣がわかってないですが、dpという変数名より中の内容を表した変数名の方がいいと思います。(num_pathsなど)
oda
reviewed
Jul 29, 2024
| continue | ||
| } | ||
|
|
||
| if x == 0 && y == 0 { |
There was a problem hiding this comment.
この条件はループの外に出していい気がします。
あと、空行が少し多いですね。あまり読む助けになりません。
oda
reviewed
Jul 29, 2024
Comment on lines
+97
to
+107
| if x == 0 { | ||
| dp[y][x] = dp[y - 1][x] | ||
| continue | ||
| } | ||
|
|
||
| if y == 0 { | ||
| dp[y][x] = dp[y][x - 1] | ||
| continue | ||
| } | ||
|
|
||
| dp[y][x] = dp[y - 1][x] + dp[y][x - 1] |
There was a problem hiding this comment.
色々な初期化の選択肢がありますね(自分のやつで恐縮ですが https://github.com/nittoco/leetcode/pull/27/files)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/unique-paths-ii/description/