Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| } | ||
|
|
||
| return nil | ||
| } |
There was a problem hiding this comment.
UnmarshalBinary panics on malformed input data
Medium Severity
UnmarshalBinary never checks the return value j from binary.Uvarint. When j == 0 (buffer too small) or j < 0 (overflow), the index i fails to advance correctly, leading to reading garbage. More critically, the slices data[i : i+int(c)] for PreRelease and BuildMeta have no bounds check — a crafted or corrupted input with a large length prefix c causes an out-of-bounds panic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Scope of changes
Adds YAML parsing to semver.
Type of change
Author checklist
Note
Medium Risk
Moderate risk because it introduces new binary/YAML encoding paths and manual byte parsing that could affect interoperability or expose edge-case panics on malformed input.
Overview
Adds YAML support for
semver.VersionviaMarshalYAML/UnmarshalYAML, plus a new compact binary encoding withMarshalBinary/UnmarshalBinaryand anErrDataSizeerror for invalid payloads.Updates
semvertests to round-trip versions through binary/text/JSON more thoroughly (YAML test stub is present but skipped), and addsyamlstruct tags toregion.Infoso region metadata can be loaded from YAML in addition to JSON/env.Written by Cursor Bugbot for commit 88e59c4. Configure here.