Skip to content

feat(codex): pass through codex client identity headers#2333

Merged
luispater merged 1 commit intodevfrom
codex
Mar 25, 2026
Merged

feat(codex): pass through codex client identity headers#2333
luispater merged 1 commit intodevfrom
codex

Conversation

@hkfires
Copy link
Copy Markdown
Collaborator

@hkfires hkfires commented Mar 25, 2026

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Codex integration by enabling the transparent forwarding of several client identity headers from incoming requests to the upstream Codex service. This ensures that crucial client-specific metadata, such as the client's version and request identifiers, is preserved throughout the communication chain, which can aid in debugging, analytics, and service-side processing. The changes also include an update to the default user agent string and robust test cases to confirm the intended behavior.

Highlights

  • Client Identity Header Passthrough: Implemented the passthrough of client-provided 'Originator', 'Version', 'X-Codex-Turn-Metadata', and 'X-Client-Request-Id' headers for both HTTP and WebSocket requests to the Codex service.
  • Updated Codex User Agent: The default 'codexUserAgent' constant has been updated to reflect a newer client version (0.116.0).
  • Refined Originator Header Logic: The logic for setting the 'Originator' header now prioritizes client-provided values from the incoming request before falling back to a default value.
  • Comprehensive Test Coverage: New unit tests were added to validate the correct passthrough behavior of these client identity headers and to ensure they are not injected by default when not provided by the client.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Codex client headers, including User-Agent, Version, Originator, X-Codex-Turn-Metadata, and X-Client-Request-Id, and introduces a new codexOriginator constant. The logic for setting the Originator header has been updated to prioritize ginHeaders and use the new constant. Corresponding tests have been added to verify the correct application and passthrough of these headers for both HTTP and WebSocket requests. A minor re-indentation was also made in antigravity_claude_request.go. The review suggests refactoring the duplicated Originator header logic into a shared helper function to improve maintainability.

Comment on lines +668 to +672
if originator := strings.TrimSpace(ginHeaders.Get("Originator")); originator != "" {
r.Header.Set("Originator", originator)
} else if !isAPIKey {
r.Header.Set("Originator", codexOriginator)
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The logic for setting the Originator header is duplicated in applyCodexWebsocketHeaders. To improve maintainability and reduce code duplication, consider extracting this logic into a shared helper function within the executor package. For example:

func setOriginatorHeader(target http.Header, source http.Header, isAPIKey bool) {
	if originator := strings.TrimSpace(source.Get("Originator")); originator != "" {
		target.Set("Originator", originator)
	} else if !isAPIKey {
		target.Set("Originator", codexOriginator)
	}
}

This function could then be called from both applyCodexHeaders and applyCodexWebsocketHeaders.

@luispater luispater merged commit d2f652f into dev Mar 25, 2026
1 of 2 checks passed
@luispater luispater deleted the codex branch March 25, 2026 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants