Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new latency breakdown feature in the usage tab, which calculates and displays the average, minimum, and maximum latency from model details. It includes the necessary internationalization keys for English and Chinese, as well as comprehensive unit tests for the new rendering logic. I have no further feedback to provide as the comments provided were non-actionable suggestions without specific code improvements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks changes from PR #2438 onto
dev.main)This brings the TUI usage details time display into
dev.