Fix PHP file language detection to enable specialized transformer#12
Merged
royisme merged 2 commits intoclaude/review-codebase-rag-011CUoMJjvbkkuZgnAHnRFvnfrom Nov 5, 2025
Merged
Conversation
Co-authored-by: royisme <350731+royisme@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on v0.6 implementation summary documentation
Fix PHP file language detection to enable specialized transformer
Nov 5, 2025
royisme
approved these changes
Nov 5, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where PHP files were not being routed to the specialized PHP transformer (_transform_php_code) because they lacked language metadata during file processing. The fix adds .php to the file extension check in extract_file_metadata(), enabling proper language detection for PHP files.
Key Changes:
- Added
.phpextension to the file type check inextract_file_metadata()to enable language metadata assignment for PHP files
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PHP transformer (
_transform_php_code) was never executed because.phpfiles weren't tagged with language metadata during file processing.Changes
.phpto the file extension list inextract_file_metadata()(services/pipeline/base.py:180)This enables PHP files to be routed to the specialized transformer instead of falling through to the generic code handler. The language mapping
.php→"php"already existed inget_language_from_extension().💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.