Open
Conversation
- Updated canvas size based on device screen
Owner
|
This is very interesting. However, many of the random parameters that are used to draw the wallpaper use boundaries based on the 16:9 aspect ratio. For portrait aspects, I think you'd want more layers for instance, and perhaps fewer segments. I'll have to think about this. Also, aren't mobile wallpapers usually square-ish? This allows that nice sliding effect when you swipe between home screens? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In addition to the other UI/UX improvements I did today (#5), I tried to make the wallpaper engine adaptive to the device screen. This way, it can generated 16:10 wallpapers, instead of 16:9 ratio when needed, and it works for mobile too (though it might require a bit of tweaking with the values to make it a bit more relevant)! The only "down side" is that it won't be a "4K wallpaper generator" anymore, so it's up to you!
The advantage of this is that one "seed" can be used on desktop, and mobile, getting a similar result, but adapted to the screen size!
Changes
Result
Reference:
From mobile
To desktop
From desktop
To mobile