Open
Conversation
iajrz
reviewed
Jun 8, 2020
Makefile
Outdated
| @@ -1,7 +1,7 @@ | |||
| CC=clang++ | |||
| CC=g++ | |||
There was a problem hiding this comment.
Drive by comment: I don't think changing the compiler is necessary. There don't seem to be g++ specific extensions or peculiarities being used anywhere. Perhaps whomever wants to compile with (not clang++) can be specified as a environment variable? (à la make -CC=g++). <3 ltns, hope you're doing well Ray
Contributor
Author
There was a problem hiding this comment.
Nice catch @iajrz. I didn't mean to commit that particular change. I changed the compiler locally since I didn't have clang++ installed on my system. I'll update the Pull Request to remove this compiler change.
Contributor
Author
There was a problem hiding this comment.
Done @iajrz . I've set the compiler back to clang++.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made some minor changes in order to make the code able to build on Ubuntu 20.04 LTS.