Conversation
rsc
reviewed
Oct 2, 2025
| } | ||
| switch idx := find(obj, n.Names); { | ||
| case idx < 0: | ||
| snap.ErrorAt(obj.Pos(), "cannot delete declaration of %s (more than 1 field)", obj.Name()) |
| } | ||
| switch idx := find(n, fl); { | ||
| case idx < 0: | ||
| snap.ErrorAt(obj.Pos(), "cannot delete declaration of %s", obj.Name()) |
Owner
There was a problem hiding this comment.
Whatever the error is, this one should match.
| case idx == 0: | ||
| start := n.Names[idx].Pos() | ||
| end := n.Names[idx+1].Pos() - 1 // delete trailing comma | ||
| // start, end := nodeRange(snap, n.Names[idx]) |
dr2chase
reviewed
Oct 2, 2025
| } | ||
| switch idx := find(obj, n.Names); { | ||
| case idx < 0: | ||
| snap.ErrorAt(obj.Pos(), "cannot delete declaration of %s (more than 1 field)", obj.Name()) |
There was a problem hiding this comment.
"more than 1 field" seems like the wrong error message now.
dr2chase
approved these changes
Oct 2, 2025
dr2chase
left a comment
dr2chase
left a comment
There was a problem hiding this comment.
I have no idea how to operate this review tool, but this overall LGTM.
This commit adds support for removing items within a list, most notably function parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for removing items within a list, most notably function parameters.