Merged
Conversation
jitsu-net
force-pushed
the
implement-mv-func-method
branch
from
8be7a9f to
b64a88c
Compare
dr2chase
reviewed
Oct 13, 2025
|
|
||
| snap.ForEachFile(func(pkg *refactor.Package, file *ast.File) { | ||
| refactor.Walk(file, func(stack []ast.Node) { | ||
| id, ok := stack[0].(*ast.Ident) |
There was a problem hiding this comment.
Should this code be watching for
funcVar := f
?
(where f is the global function that is being converted to a method)
There was a problem hiding this comment.
or, also, someOtherfunc(f)
or any other use of a function that is not a call?
Collaborator
Author
There was a problem hiding this comment.
Good point; I will add support for those cases.
dr2chase
reviewed
Oct 13, 2025
|
|
||
| snap.ForEachFile(func(pkg *refactor.Package, file *ast.File) { | ||
| refactor.Walk(file, func(stack []ast.Node) { | ||
| id, ok := stack[0].(*ast.Ident) |
There was a problem hiding this comment.
or, also, someOtherfunc(f)
or any other use of a function that is not a call?
jitsu-net
force-pushed
the
implement-mv-func-method
branch
from
b64a88c to
2ec3cfb
Compare
This change implements the moving of a function to a method. The receiver of the method must match the first parameter to the funciton.
jitsu-net
force-pushed
the
implement-mv-func-method
branch
from
2ec3cfb to
dcd4416
Compare
Collaborator
Author
|
Updated; please let me know if I missed any edge cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change implements the 'mv TFunction T.Method' command.