share dir not returned for constructs like eval qq{$pkg_name}

[shawnlaffan]

This is a follow on from #12 except this time the package name is in a variable so static scanning will not detect it. I assume the logic associated with the -x flag needs to be updated.

This is using scandeps.pl from ea35db3

This finds the share dir:

scandeps.pl -x -e 'eval qq{require Inline::C}' -V | grep 'Inline'
# Inline.pm [module]
# Inline/C.pm [module]
# Inline/C/Parser/RecDescent.pm [module]
# Inline/MakeMaker.pm [module]
# Inline/denter.pm [module]
# auto/share/dist/Inline-C/inline-c.pgx [data]
'Inline'                        => '0', #    ? # Inline::C
'Inline::C'                     => '0', #    ? # hr2HuoGwt7
'Inline::C::Parser::RecDescent' => '0', #    ? # Inline::C
'Inline::MakeMaker'             => '0', #    ? # Inline
'Inline::denter'                => '0', #    ? # Inline
'Parse::RecDescent'             => '0', #    ? # Inline::C::Parser::RecDescent

This does not find the share dir, and is also missing several other components (the same differences as in #12):

scandeps.pl -x -e 'my $pkg = "Inline::C"; eval qq{require $pkg}' -V | grep 'Inline'
# Inline.pm [module]
# Inline/C.pm [module]
# Inline/denter.pm [module]
'Inline'         => '0', #    ? #
'Inline::C'      => '0', #    ? #
'Inline::denter' => '0', #    ? #

[shawnlaffan]

So far as I can tell the issue is that the %INC processing in _info2rv does not add data under the uses key (and perhaps other info). The share dir is listed under the uses key when a module is detected under static scanning.

Does it need to call _add_info instead of directly populating the hash?

Module-ScanDeps/lib/Module/ScanDeps.pm

Lines 1539 to 1550 in ea35db3

	foreach my $key (keys %{ $info->{'%INC'} }) {
	(my $path = $info->{'%INC'}{$key}) =~ s:\\:/:g;
	$key =~ s:\\:/:g;
	$key =~ s/$strip_inc_prefix// if File::Spec->file_name_is_absolute($key);
	$rv->{$key} = {
	'used_by' => [],
	'file' => $path,
	'type' => _gettype($path),
	'key' => $key
	};
	}

[rschupp]

So far as I can tell the issue is that the %INC processing in _info2rv does not add data under the uses key

_info2rv has no information about uses et al. - scan_deps_runtime basically returns a flat list of modules name (and the files they were loaded from) and shared libraries.

Anyway, uses is a red herring. Share dir detection is done in add_deps which is called only for the toplevel input files of scan_deps and recursively from scan_deps_static. But in your example Inline::C is only detected by scan_deps_runtime, hence it doesn't get the add_deps treatment.