Merged
Conversation
There was a problem hiding this comment.
Pull request overview
UI polish and interaction improvements for the sview Qt application, focusing on a more cohesive dark theme, richer navigation affordances (breadcrumbs/loading), and faster item discovery/inspection (type-to-filter + thumbnails).
Changes:
- Refines dark theme styling and adds styling hooks for new UI elements (breadcrumb bar, loading overlay/spinner, search input).
- Introduces custom-drawn icons and updates table/icon views to use them (plus type-to-filter keyboard handling).
- Enhances the inspector panel with a scrollable layout and image thumbnail previews; adjusts scanner behavior to treat directory symlinks as directories and adds a regression test.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
tests/test_scanner.py |
Adds a regression test for directory symlink classification. |
sview/scanner.py |
Changes raw item classification to follow symlinks when detecting directories. |
sview/qt/table.py |
Uses custom icons and adds key handling/signals for type-to-filter behavior. |
sview/qt/main_window.py |
Adds breadcrumb bar + status loading UI, wires filter key signals, and updates layout/focus behavior. |
sview/qt/inspector.py |
Makes inspector scrollable and adds thumbnail preview generation/resizing behavior. |
sview/qt/icons.py |
New module implementing custom-drawn file/folder/sequence icons. |
sview/qt/icon_view.py |
Uses custom icons, adjusts sizing/spacing, and adds type-to-filter key handling/signals. |
sview/qt/app.py |
Updates palette + stylesheet for the refined dark theme and new widget object names. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes significant improvements to the user interface and code structure for the sview application, focusing on enhanced visual consistency, a richer dark theme, improved filtering, and better item inspection. The most important changes are grouped below.
UI Theming and Visual Improvements
sview/qt/app.py). [1] [2] [3] [4] [5]sview/qt/icon_view.py). [1] [2]Custom Icons
sview/qt/icons.pymodule providing lightweight, custom-drawn icons for directories, files, and sequences, replacing the use of standard Qt icons for a more distinctive look (sview/qt/icons.py,sview/qt/icon_view.py). [1] [2] [3]Filtering and Keyboard Interaction
sview/qt/icon_view.py). [1] [2]Inspector Panel Enhancements
sview/qt/inspector.py). [1] [2] [3] [4] [5] [6]These changes collectively provide a more modern, visually appealing, and interactive user interface, while also improving code modularity and maintainability.