Skip to content

Feature/UI polish pass#2

Merged
rsgalloway merged 7 commits intomasterfrom
feature/ui-polish-pass
Apr 5, 2026
Merged

Feature/UI polish pass#2
rsgalloway merged 7 commits intomasterfrom
feature/ui-polish-pass

Conversation

@rsgalloway
Copy link
Copy Markdown
Owner

@rsgalloway rsgalloway commented Apr 5, 2026

This pull request makes significant improvements to the user interface and code structure for the sview application, focusing on enhanced visual consistency, a richer dark theme, improved filtering, and better item inspection. The most important changes are grouped below.


UI Theming and Visual Improvements

  • Refined the dark theme with improved color choices for backgrounds, buttons, highlights, and various widgets, resulting in a more cohesive and visually appealing interface. Added custom styling for menu bars, breadcrumb bars, loading overlays, and other UI elements (sview/qt/app.py). [1] [2] [3] [4] [5]
  • Increased icon sizes and spacing in the icon view for better clarity and aesthetics (sview/qt/icon_view.py). [1] [2]

Custom Icons

  • Introduced a new sview/qt/icons.py module providing lightweight, custom-drawn icons for directories, files, and sequences, replacing the use of standard Qt icons for a more distinctive look (sview/qt/icons.py, sview/qt/icon_view.py). [1] [2] [3]

Filtering and Keyboard Interaction

  • Added signals and keyboard event handling to the icon view, enabling users to filter items by typing, and clear or backspace the filter using keyboard shortcuts (sview/qt/icon_view.py). [1] [2]

Inspector Panel Enhancements

  • Enhanced the inspector panel to display image thumbnails for items, including logic to load, scale, and update the preview when the panel is resized. The panel layout is now scrollable and more robust, providing a better experience for inspecting item details (sview/qt/inspector.py). [1] [2] [3] [4] [5] [6]

These changes collectively provide a more modern, visually appealing, and interactive user interface, while also improving code modularity and maintainability.

@rsgalloway rsgalloway self-assigned this Apr 5, 2026
@rsgalloway rsgalloway added the enhancement New feature or request label Apr 5, 2026
@rsgalloway rsgalloway marked this pull request as ready for review April 5, 2026 21:45
@rsgalloway rsgalloway requested a review from Copilot April 5, 2026 22:10
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

UI polish and interaction improvements for the sview Qt application, focusing on a more cohesive dark theme, richer navigation affordances (breadcrumbs/loading), and faster item discovery/inspection (type-to-filter + thumbnails).

Changes:

  • Refines dark theme styling and adds styling hooks for new UI elements (breadcrumb bar, loading overlay/spinner, search input).
  • Introduces custom-drawn icons and updates table/icon views to use them (plus type-to-filter keyboard handling).
  • Enhances the inspector panel with a scrollable layout and image thumbnail previews; adjusts scanner behavior to treat directory symlinks as directories and adds a regression test.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tests/test_scanner.py Adds a regression test for directory symlink classification.
sview/scanner.py Changes raw item classification to follow symlinks when detecting directories.
sview/qt/table.py Uses custom icons and adds key handling/signals for type-to-filter behavior.
sview/qt/main_window.py Adds breadcrumb bar + status loading UI, wires filter key signals, and updates layout/focus behavior.
sview/qt/inspector.py Makes inspector scrollable and adds thumbnail preview generation/resizing behavior.
sview/qt/icons.py New module implementing custom-drawn file/folder/sequence icons.
sview/qt/icon_view.py Uses custom icons, adjusts sizing/spacing, and adds type-to-filter key handling/signals.
sview/qt/app.py Updates palette + stylesheet for the refined dark theme and new widget object names.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rsgalloway rsgalloway merged commit 8ff7fc1 into master Apr 5, 2026
36 checks passed
@rsgalloway rsgalloway deleted the feature/ui-polish-pass branch April 5, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants