Unsubscribe from the connection before shutdown the RS.#107
Merged
NiteshKant merged 2 commits intomasterfrom Jun 28, 2016
Merged
Unsubscribe from the connection before shutdown the RS.#107NiteshKant merged 2 commits intomasterfrom
shutdown the RS.#107NiteshKant merged 2 commits intomasterfrom
Conversation
**Problem** When we close a ReactiveSocket, it closes the underlying DuplexConnection which trigger an unnecessary onError on the Requester/Responder. **Solution** Store the disposable of the DuplexConnection subscription as an instance variable, and dispose it before closing the DuplexConnection. **Modification** I also added a `name` method in Requester/Responder to simplify debugging code where we have client and server in the same JVM. It now shows which Requester/Responder is generating an error, the client's one or the server's one.
| public void shutdown() { | ||
| // TODO do something here | ||
| System.err.println("**** Requester.shutdown => this should actually do something"); | ||
| Disposable disposable = connectionSubscription.getAndSet(CANCELLED); |
Contributor
There was a problem hiding this comment.
nit: EmptyDisposable (CANCELLED here) ignores dispose call, so you don't need && disposable != CANCELLED check here.
This was referenced Jun 28, 2016
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When we close a ReactiveSocket, it closes the underlying DuplexConnection
which trigger an unnecessary onError on the Requester/Responder.
Solution
Store the disposable of the DuplexConnection subscription as an instance
variable, and dispose it before closing the DuplexConnection.
Modification
I also added a
namemethod in Requester/Responder to simplify debuggingcode where we have client and server in the same JVM.
It now shows which Requester/Responder is generating an error, the client's
one or the server's one.