Skip to content

#1077 type safe discard element consumer#1079

Closed
luczus wants to merge 1 commit intorsocket:masterfrom
luczus:sendUtils_on_discard
Closed

#1077 type safe discard element consumer#1079
luczus wants to merge 1 commit intorsocket:masterfrom
luczus:sendUtils_on_discard

Conversation

@luczus
Copy link
Copy Markdown

@luczus luczus commented Dec 1, 2022

Discard element consumer is accepting other elements than ReferenceCounted

Motivation:

When I use DefaultRSocketClient in logs files I see warning log entries like:

] WARN  reactor.core.publisher.Operators        : Error in discard hook
java.lang.ClassCastException: class org.springframework.core.io.buffer.NettyDataBuffer cannot be cast to class io.netty.util.ReferenceCounted (org.springframework.core.io.buffer.NettyDataBuffer and io.netty.util.ReferenceCounted are in unnamed module of loader 'app')

Modifications:

Make discard consumer accept other types than ReferenceCounted parameter and avoid having warnings in logs

Result:

The warning log entries are not created by DefaultRSocketClient.

@kmccarp
Copy link
Copy Markdown

kmccarp commented Mar 3, 2023

Is there any plan to integrate this? This is heavily polluting our logs.

@OlegDokuka OlegDokuka added the superseded Issue is superseded by another label Apr 24, 2023
@OlegDokuka
Copy link
Copy Markdown
Member

close in favor of #1091

@OlegDokuka OlegDokuka closed this Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

superseded Issue is superseded by another

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants