Add an overload of TcpReactiveSocketServer.create with SocketAddress.#108
Merged
NiteshKant merged 1 commit intomasterfrom Jun 28, 2016
Merged
Conversation
**Problem** It is impossible to specify the network interface to use when starting a server. This can be problematic when we want to design test that run in restricted environment (e.g. CI). **Solution** Create an overload of `TcpReactiveSocketServer.create` that accept a SocketAddress instead of just the port.
ilayaperumalg
pushed a commit
to ilayaperumalg/rsocket-java
that referenced
this pull request
Dec 26, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
It is impossible to specify the network interface to use when starting a server.
This can be problematic when we want to design test that run in restricted
environment (e.g. CI).
Solution
Create an overload of
TcpReactiveSocketServer.createthat accept aSocketAddress instead of just the port.