Local transport now uses tcp.#135
Closed
NiteshKant wants to merge 1 commit intorsocket:masterfrom
Closed
Conversation
#### Problem Local transport was using a custom local socket implementation. Netty provides a `LocalChannel` abstraction that can be used. #### Modification Modified `reactivesocket-transport-local` to use `reactivesocket-transport-tcp`.
Member
|
I agree with the rationale for the change, but some tests are failing. |
Contributor
Author
|
Yeah I haven't gotten time to dig deep on the failing tests. |
Contributor
Author
|
Closing this since we are removing local transport (PR #142) |
ilayaperumalg
pushed a commit
to ilayaperumalg/rsocket-java
that referenced
this pull request
Dec 26, 2017
* add resume behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Local transport was using a custom local socket implementation.
Netty provides a
LocalChannelabstraction that can be used.Modification
Modified
reactivesocket-transport-localto usereactivesocket-transport-tcp.