ClientBuilder.build is now asynchronous.#141
Merged
NiteshKant merged 3 commits intomasterfrom Jul 12, 2016
Merged
Conversation
***Problem*** The ClientBuilder `build` API return a ReactiveSocket. This ReactiveSocket is returned while connections are still in establishing mode, then it will fail until the connections established. The current solution is to call `Unsafe.awaitAvailability` which is cluncky. ***Solution*** Create a more robust API that return a `Publisher<ReactiveSocket>`, it is now obvious that the API is asynchronous. ***Modification*** I found a bug in `sourceToFactory`, where I was calling `subscriber.onSubscribe` before initializing the `current` Map.
| sourceToFactory(source, filterConnector); | ||
| LoadBalancer<T> loadBalancer = new LoadBalancer<>(factories); | ||
|
|
||
| scheduledFuture = executor.scheduleAtFixedRate(() -> { |
Contributor
There was a problem hiding this comment.
May be we should do null check for executor in withExecutor, since you are assuming it to be non-null.
Contributor
|
👍 apart from the small comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_Problem_
The ClientBuilder
buildAPI return a ReactiveSocket.This ReactiveSocket is returned while connections are still in establishing
mode, then it will fail until the connections established.
The current solution is to call
Unsafe.awaitAvailabilitywhich is cluncky._Solution_
Create a more robust API that return a
Publisher<ReactiveSocket>, it is nowobvious that the API is asynchronous.
_Modification_
I found a bug in
sourceToFactory, where I was callingsubscriber.onSubscribebefore initializing the
currentMap.