ReactiveSocket: Remove startAndWait method#143
Merged
NiteshKant merged 3 commits intomasterfrom Jul 13, 2016
Merged
Conversation
***Problem*** ReactiveSocket shouldn't have a public API encouraging usage of blocking code. ***Solution*** Remove the method, replace it by `start` where it was easy and by `Unsafe.startAndWait` elsewhere.
Member
Author
|
This needs to be merged after the removal of |
Contributor
|
@stevegury looks like removal of local transport (#142) is included in this PR, Otherwise it is 👍 |
Member
Author
|
Yes, I'll merge master as soon as the removal of the local transport is merged. |
Member
Author
|
I added back local-transport. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_Problem_
ReactiveSocket shouldn't have a public API encouraging usage of blocking code.
_Solution_
Remove the method, replace it by
startwhere it was easy andby
Unsafe.startAndWaitelsewhere.