provides supportive class to hide concurrency complexity#807
Merged
OlegDokuka merged 7 commits intodevelopfrom May 1, 2020
Merged
provides supportive class to hide concurrency complexity#807OlegDokuka merged 7 commits intodevelopfrom
OlegDokuka merged 7 commits intodevelopfrom
Conversation
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
…ttern Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
OlegDokuka
force-pushed
the
enhancement/reduce-maintanence-complexity
branch
from
0e716a5 to
6c4c075
Compare
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
OlegDokuka
commented
Apr 30, 2020
OlegDokuka
commented
Apr 30, 2020
OlegDokuka
commented
Apr 30, 2020
rstoyanchev
requested changes
May 1, 2020
Contributor
rstoyanchev
left a comment
rstoyanchev
left a comment
There was a problem hiding this comment.
Looks good, much easier to read the request logic. Some minor changes requested.
| CancelFrameFlyweight.encode(allocator, streamId)); | ||
| } else { | ||
| payload.release(); | ||
| } |
Contributor
There was a problem hiding this comment.
Nice one! Avoiding the reliance on the refCnt to check if the request was sent.
Co-authored-by: Rossen Stoyanchev <rstoyanchev@users.noreply.github.com>
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes extra supportive class which should be used only for requestXXX interactions via
Operators.liftin order to simplify business logic insideRSocketRequester(e.g. wipLoops andcancel/requestsignals serialization)Also, this PR, ensures that
streamIdwill be generated exactly during the first request phase so we will not waste sequence in case stream was not subscribed. The same is relevant toholders which are going to get logical stream
putin it only in case of successful subscription to the generated interaction with the subsequentrequest(n)call on it.Note.
StreamIdshould not be issued until the firstrequestNas well as the holders should not store anything prior to the first frame sent (it means that if cancel signal happened prior the first request, the only thing we have to do is releasing given payload)Signed-off-by: Oleh Dokuka shadowgun@i.ua