provides extra @NonNullApi annotation for all packages#826
Merged
OlegDokuka merged 3 commits intodevelopfrom May 8, 2020
Merged
provides extra @NonNullApi annotation for all packages#826OlegDokuka merged 3 commits intodevelopfrom
OlegDokuka merged 3 commits intodevelopfrom
Conversation
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
OlegDokuka
force-pushed
the
enhancement/non-null-api
branch
from
0a54108 to
d5c3c54
Compare
spencergibb
approved these changes
May 8, 2020
|
@OlegDokuka is |
Member
Author
|
@robotmrv let me see if that is really needed |
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Member
Author
|
@robotmrv fixed. Should be |
rstoyanchev
approved these changes
May 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides some enhancement from the API documentation perspective and provides all the packages with
NonNullApiannotation. Also, it provides fixes where it is needed to ensure that all places whereNullabilityis allowed are annotated appropriately.Signed-off-by: Oleh Dokuka shadowgun@i.ua