removes limit rate operator#829
Merged
OlegDokuka merged 3 commits intodevelopfrom May 10, 2020
Merged
Conversation
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
rstoyanchev
approved these changes
May 10, 2020
Contributor
rstoyanchev
left a comment
rstoyanchev
left a comment
There was a problem hiding this comment.
I agree it's fine to leave this up to applications to plug in .
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #825
This PR removes usage of
limitRateoperator and provides an example of how one can providelimitRatejust in case this is crucial