fixes DefaultPayload.create(ByteBuf, ByteBuf) to release params#886
Merged
OlegDokuka merged 1 commit into1.0.xfrom Jul 18, 2020
Merged
fixes DefaultPayload.create(ByteBuf, ByteBuf) to release params#886OlegDokuka merged 1 commit into1.0.xfrom
DefaultPayload.create(ByteBuf, ByteBuf) to release params#886OlegDokuka merged 1 commit into1.0.xfrom
Conversation
This PR makes `DefaultPayload.create(ByteBuf, ByteBuf)` behaves consistent with `ByteBufPayload.create(ByteBuf, ByteBuf)` method. Please note, both methods do not require a user to take any further actions on releasing provided data and metadata `ByteBuf`s. This is a responsibility of the Payload to do so immediately (in the case of `DefaultPayload`) or later, upon the release faze (in case of `ByteBufPayload`) Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
OlegDokuka
force-pushed
the
bugfix/default-payload-create-refcnt
branch
from
04c379c to
9b04a75
Compare
spencergibb
approved these changes
Jul 7, 2020
rstoyanchev
approved these changes
Jul 18, 2020
yschimke
approved these changes
Jul 18, 2020
Member
yschimke
left a comment
yschimke
left a comment
There was a problem hiding this comment.
It seems worth documenting this behaviour in javadocs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #882
This PR makes
DefaultPayload.create(ByteBuf, ByteBuf)behaves consistent withByteBufPayload.create(ByteBuf, ByteBuf)method.Please note, both methods do not require a user to take any further actions on releasing provided data and metadata
ByteBufs. This is a responsibility of the Payload to do so immediately (in the case ofDefaultPayload) or later, upon the release faze (in case ofByteBufPayload)Signed-off-by: Oleh Dokuka shadowgun@i.ua