i18n_set_language_option() sets env var to translate R messages#558
Merged
gadenbuie merged 18 commits intorstudio:masterfrom Jul 28, 2021
Merged
i18n_set_language_option() sets env var to translate R messages#558gadenbuie merged 18 commits intorstudio:masterfrom
i18n_set_language_option() sets env var to translate R messages#558gadenbuie merged 18 commits intorstudio:masterfrom
Conversation
gadenbuie
reviewed
Jul 20, 2021
rossellhayes
force-pushed
the
i18n-env-var
branch
from
68ad547 to
c464f80
Compare
…alidate the cache so new messages have to generate
gadenbuie
reviewed
Jul 22, 2021
…iant of a translated language (e.g. `pt` will inherit `pt_BR`)
gadenbuie
approved these changes
Jul 27, 2021
Member
gadenbuie
left a comment
gadenbuie
left a comment
There was a problem hiding this comment.
Looks great! Pending small changes and a NEWS entry this is ready to go 🚀
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
…into i18n-env-var
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
…into i18n-env-var
gadenbuie
reviewed
Jul 28, 2021
gadenbuie
reviewed
Jul 28, 2021
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR expands
i18n_set_language_option(). In addition to setting aknitroption to translate thelearnrinterface, it will also now set an environment variable to translate R messages. This will allow users to receive feedback from R, includinggradethisfeedback, in their own language (when translations are available).