Skip to content

Conversation

@daattali
Copy link
Contributor

Fixes #61

@schloerke
Copy link
Collaborator

Thank you for the PR, @daattali !

Could we change reactlog_set() to two functions: reactlog_enable() and reactlog_disable(warn = TRUE)?

With reactlog_disable(warn = TRUE), it should display a warning like "Restart R to free up 'reactlog' memory" if isTRUE(warn)`

(Feel free to put them under the same Rd file)

@schloerke schloerke self-assigned this Feb 19, 2020
@daattali daattali changed the title add a reactlog_set() instead of having to set the R option add a reactlog_enable()/reactlog_disable() instead of having to set the R option Feb 19, 2020
@daattali
Copy link
Contributor Author

@dtkaplan this is for you!

@schloerke
Copy link
Collaborator

Thank you!

@schloerke schloerke added this to the v1.1.0 milestone Feb 19, 2020
@schloerke schloerke merged commit f078d88 into rstudio:master Feb 19, 2020
@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reactlog should provide a function for setting options(shiny.reactlog=TRUE)

3 participants