Skip to content
This repository was archived by the owner on Aug 22, 2025. It is now read-only.

GH-139: [rt_media attachment_id=XX] short does not work [Develop]#259

Merged
Pathan-Amaankhan merged 1 commit intodevelopfrom
fix/shortcode-rt_media
Feb 3, 2023
Merged

GH-139: [rt_media attachment_id=XX] short does not work [Develop]#259
Pathan-Amaankhan merged 1 commit intodevelopfrom
fix/shortcode-rt_media

Conversation

@Pathan-Amaankhan
Copy link
Copy Markdown
Member

Description

  • This PR:
    • adds a message to the rt_media shortcode when the image attachment ID is added in attachment_id.
    • Fixes the Undefined variable: $media_url by initializing $media_url with a default value(.i.e. '').

Fixes/Covers

@Pathan-Amaankhan Pathan-Amaankhan marked this pull request as draft February 2, 2023 13:54
@Pathan-Amaankhan Pathan-Amaankhan changed the base branch from develop to GH-31 February 3, 2023 06:54
@Pathan-Amaankhan Pathan-Amaankhan changed the base branch from GH-31 to develop February 3, 2023 06:55
@Pathan-Amaankhan Pathan-Amaankhan marked this pull request as ready for review February 3, 2023 06:57
@Pathan-Amaankhan Pathan-Amaankhan merged commit 3089c59 into develop Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants