GH-179 : Implement nonce verification for Ajax calls#285
GH-179 : Implement nonce verification for Ajax calls#285SohamPatel46 merged 10 commits intomasterfrom
Conversation
Dismissing review as all inline comments are obsolete by now
AnuragVasanwala
left a comment
There was a problem hiding this comment.
LGTM ✅
Let's wait for @gagan0123's review.
|
Can you please check why "End-to-End Tests / Playwright Tests (pull_request) " is failing and fix that before the PR is merged? |
|
@gagan0123 Implemented specific nonce creation for every action. Still there are 2 ajax callbacks whose action can't be located in the codebase - https://github.com/rtCamp/transcoder/blob/master/admin/rt-transcoder-handler.php#L183-#L184 |
@SohamPatel46 You can remove that part of code, I've verified that it was used before, but later the functionality was removed without removing the WP AJAX endpoints.
|
|
@gagan0123 Removed unused AJAX actions and callback. Can you re-review it ? |
|
Thanks @SohamPatel46 for the PR 👍 @pavanpatil1 can you please test this branch to ensure the functionality is not impacted. Code looks good to me. |
Description