Skip to content
This repository was archived by the owner on Aug 22, 2025. It is now read-only.

Update Node Packages#305

Merged
Vedant-Gandhi merged 16 commits intodevelopfrom
build/update-packages
Mar 4, 2025
Merged

Update Node Packages#305
Vedant-Gandhi merged 16 commits intodevelopfrom
build/update-packages

Conversation

@Vedant-Gandhi
Copy link
Copy Markdown
Contributor

@Vedant-Gandhi Vedant-Gandhi commented Feb 26, 2025

Changes made

This PR addresses the following changes:

  • Update NodeJS packages in e2e tests to fix the dependabot errors.
  • Update transcoder NodeJS packages to update compatibility with NodeJS 20.

Ref - #302

@Vedant-Gandhi Vedant-Gandhi marked this pull request as ready for review February 26, 2025 11:28
Comment thread package.json
@@ -6,39 +6,41 @@
"dev": "cross-env BABEL_ENV=default webpack --watch --mode development --progress"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running this changeset gives us a dependency error because of grunt.

Screenshot 2025-02-27 at 1 34 09 PM

Also, why have we not pushed the package-lock.json file?

Detailed log:
2025-02-27T08_01_29_206Z-debug-0.log

Steps to reproduce:

  1. Clone a new repo.
  2. Checkout build/update-packages branch.
  3. Run: nvm use && npm install.

Copy link
Copy Markdown
Contributor Author

@Vedant-Gandhi Vedant-Gandhi Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pathan-Amaankhan The error is because of grunt-autoprefixer which is deprecated by grunt-postcss which is also archived, and there is no replacement package for that. After reading the current commands, I have not found use case where we are currently using grunt pipeline so I have preserved them if they are used elsewhere in CI/CD.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vedant-Gandhi,
We are using grunt-autoprefixer in Gruntfile.js.
A better alternative for grunt-autoprefixer can be autoprefixer.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pathan-Amaankhan Okay will update it.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also update the depricated packages.
Screenshot 2025-03-03 at 1 08 44 PM

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pathan-Amaankhan I have updated the deprecated package to use @wordpress/eslint-plugin, but it has its own dependencies as eslint 8.57.1, which conflicts with our current 9.21.0. The package is working properly with no issues, so we can ignore them for now.

@Vedant-Gandhi Vedant-Gandhi merged commit 2548b3a into develop Mar 4, 2025
@Vedant-Gandhi Vedant-Gandhi deleted the build/update-packages branch March 4, 2025 14:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants