This repository was archived by the owner on Mar 12, 2025. It is now read-only.
Update deep merge() to work with an array argument #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Looks like the build failed to a credentials issue, not test failures: |
Contributor
Author
|
Just wanted to ping on this and see if anyone had any feedback. Thanks :-) |
Collaborator
|
@lelandmiller looks like a bug and a legit fix to me! @rtfeldman ? |
Contributor
Author
|
Hey, @rtfeldman! just wanted to check in on this again to see if there is anything I could do to possibly get this in a published version of seamless-immutable. Thanks! |
Owner
|
@lelandmiller really sorry I took so long getting to this! Looks good to me. If you can resolve the merge conflicts I'll merge and publish this. |
Contributor
Author
|
Closing and continuing on #156. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe I am misunderstanding how this should work. I was expecting a deep merge to deeply merge each object in an array sequentially. The behavior I expected is what I added a test for. Please let me know if I am misinterpreting the API, I can fix this in another way if you would like as well.