Skip to content

Add liquibase TOML filter#1036

Merged
FlorianBruniaux merged 1 commit intortk-ai:developfrom
s2005:feat/liquibase
Apr 13, 2026
Merged

Add liquibase TOML filter#1036
FlorianBruniaux merged 1 commit intortk-ai:developfrom
s2005:feat/liquibase

Conversation

@s2005
Copy link
Copy Markdown
Contributor

@s2005 s2005 commented Apr 5, 2026

Summary

  • add a built-in liquibase TOML filter
  • support filters that merge stderr into filtered output
  • register liquibase in discover rules and document the new filter field

Verification

  • cargo test --all
  • cargo run -- verify --filter liquibase

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 5, 2026

CLA assistant check
All committers have signed the CLA.

@pszymkowiak pszymkowiak added effort-medium 1-2 jours, quelques fichiers enhancement New feature or request labels Apr 5, 2026
@pszymkowiak
Copy link
Copy Markdown
Collaborator

[w] wshm · Automated triage by AI

📊 Automated PR Analysis

Type feature
🟡 Risk medium

Summary

Adds a new built-in liquibase TOML filter that strips banners, ASCII art, and verbose info logs from liquibase CLI output. Introduces a filter_stderr field so filters can capture and merge stderr into stdout before filtering, which is needed for tools like liquibase that emit noise to stderr. Also registers liquibase in the discover rules and documents the new field.

Review Checklist

  • Tests present
  • Breaking change
  • Docs updated

Analyzed automatically by wshm · This is an automated analysis, not a human review.

@s2005 s2005 changed the base branch from master to develop April 5, 2026 13:32
@s2005 s2005 marked this pull request as draft April 5, 2026 13:36
@s2005 s2005 marked this pull request as ready for review April 5, 2026 13:40
Copy link
Copy Markdown
Collaborator

@pszymkowiak pszymkowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on develop to clear the Cargo.toml / Cargo.lock / CHANGELOG / manifest noise — PR is now clean (1 commit, 5 files, feature-only).

Tested locally with a mock liquibase binary emitting banner on stderr:

Test Result
rtk verify --filter liquibase 4/4 passed
Real execution (raw → filtered) 705 bytes → 133 bytes (90% savings)
Empty output liquibase: ok
Error with exit 1 Error visible, exit code propagated

The filter_stderr field is a solid addition — it's a generic feature that will help other JVM tools (Maven, Gradle, Ant) that emit banners to stderr. Default is false, so no impact on existing filters.

LGTM — good to merge.

@pszymkowiak pszymkowiak requested a review from aeppling April 12, 2026 20:32
@FlorianBruniaux FlorianBruniaux merged commit a9e857e into rtk-ai:develop Apr 13, 2026
1 check passed
maxkulish added a commit to maxkulish/rtk that referenced this pull request Apr 14, 2026
Removes ASCII art header and Java startup boilerplate from Liquibase
output while preserving changeset execution list and migration result.
Saves 80%+ tokens on typical update output.

Filter strips:
- ASCII art logo (lines starting with ##)
- Verbose startup lines (Starting Liquibase at, Liquibase Version)
- Empty lines

Preserves:
- Running Changeset lines (migration execution)
- Rolling Back Changeset lines (rollback operations)
- Success/failure result lines
- ERROR messages

Includes 3 inline tests covering update success, error handling,
and rollback scenarios.

Upstream: v0.36.0 rtk-ai#1036
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort-medium 1-2 jours, quelques fichiers enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants