fix(curl): skip JSON schema conversion for internal/localhost URLs#1172
Merged
FlorianBruniaux merged 1 commit intortk-ai:developfrom Apr 13, 2026
Merged
Conversation
Collaborator
📊 Automated PR Analysis
SummaryAdds an Review Checklist
Analyzed automatically by wshm · This is an automated analysis, not a human review. |
e4126bc to
a839d59
Compare
a839d59 to
577c311
Compare
FlorianBruniaux
approved these changes
Apr 13, 2026
Collaborator
FlorianBruniaux
left a comment
There was a problem hiding this comment.
LGTM — security fix, reviewed diff, tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issues #1152 and #1157: JSON schema conversion was destroying values for internal/localhost URLs.
Problem
The curl JSON schema filter converts response bodies into type schemas, which destroys the actual values. For internal URLs (localhost, 127.0.0.1, etc.) this is problematic because:
Solution
Added
is_internal_url()helper that detects localhost/127.0.0.1/[::1] URLs. When an internal URL is detected, the JSON schema conversion is skipped, preserving the original JSON values.Changes
is_internal_url()function to detect internal URLs!is_internal_url(args)checkfilter_curl_outputsignature to accept argstest_is_internal_url_localhosttest