fix(permissions): glob_matches middle-wildcard matches commands with no trailing arguments#1200
Merged
FlorianBruniaux merged 1 commit intortk-ai:developfrom Apr 13, 2026
Conversation
…ut trailing args (rtk-ai#1105) When glob_matches processed a pattern like "git -C * diff:*" (normalized to "git -C * diff *"), middle segment " diff " requires a trailing space to match. For "git -C /path diff" the remaining text is "/path diff" which ends with " diff" — no trailing space — so .find(" diff ") returned None and the command was incorrectly rejected. Fix: in the middle-segment branch, if the full substring search fails, also check if the remaining text ends with the trimmed (right-stripped) segment. This handles commands that terminate at the middle token with no trailing arguments. Add regression test covering the exact reproduction case from the issue. Closes rtk-ai#1105 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ousamabenyounes
force-pushed
the
fix/issue-1105
branch
from
b76e160 to
3db8070
Compare
FlorianBruniaux
approved these changes
Apr 13, 2026
Collaborator
FlorianBruniaux
left a comment
FlorianBruniaux
left a comment
There was a problem hiding this comment.
LGTM — clean fix, tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
glob_matchesfailed to match commands that terminated at the middle-wildcard token with no trailing argumentsgit -C * diff:*matchedgit -C /path diff --stat(has trailing flag) but NOT baregit -C /path diffgit -C * diff:*→git -C * diff *, splitting into["git -C ", " diff ", ""]. Middle segment" diff "has a trailing space;/path diffends with" diff"(no trailing space), sostr::find(" diff ")returnsNone→ the command is incorrectly rejectedremaining.ends_with(part.trim_end())as fallback — this handles commands that end at the middle token with no trailing argsTest plan
cargo fmt --allpassescargo clippy --all-targets— no new errorscargo test --all— all 1374 tests passtest_middle_wildcard_at_end_of_command— covers both positive cases (bare command, command with args) and a negative caseCloses #1105
🤖 Generated with Ora Studio