Skip to content

fix(playwright): fix JSON parser to match real Playwright output format#193

Merged
pszymkowiak merged 1 commit intortk-ai:masterfrom
USerik:fix/playwright-json-parser
Mar 4, 2026
Merged

fix(playwright): fix JSON parser to match real Playwright output format#193
pszymkowiak merged 1 commit intortk-ai:masterfrom
USerik:fix/playwright-json-parser

Conversation

@USerik
Copy link
Copy Markdown
Contributor

@USerik USerik commented Feb 18, 2026

Three bugs caused rtk playwright test to always fail with EXIT: 1:

  1. Wrong argument order: --reporter=json was inserted before the subcommand (e.g. playwright --reporter=json test), but Playwright requires flags after the subcommand (playwright test --reporter=json).

  2. Float duration deserialization: PlaywrightStats.duration was typed as u64, but real Playwright output emits a float (e.g. 3519.703...), causing serde_json to fail with a type error.

  3. Wrong suite structure: Suites contain specs (not tests). Each spec has ok: bool and tests (per-browser executions). The old struct used tests: Vec<PlaywrightTest> directly in suites, which never matched real output and always failed JSON parsing.

Fixes:

  • Move --reporter=json to after the first arg (the subcommand)
  • Change duration: u64 to duration: f64 in PlaywrightStats
  • Rewrite PlaywrightSuite → specs: Vec<PlaywrightSpec>
  • Add PlaywrightSpec with ok: bool and tests: Vec<PlaywrightExecution>
  • Add PlaywrightExecution with status and results: Vec<PlaywrightAttempt>
  • Update PlaywrightAttempt to use errors: Vec<PlaywrightError> (array)
  • Add tests covering float duration, real suite structure, and failure details

@pszymkowiak
Copy link
Copy Markdown
Collaborator

pszymkowiak commented Feb 20, 2026

Thanks for this! Could you rebase on master? The branch is 2 commits behind. We'll review once it's up to date.

@devkeruse @claude
fix(playwright): fix JSON parser to match real Playwright output format
8f03e7e 
Three bugs caused `rtk playwright test` to always fail with EXIT: 1:

1. **Wrong argument order**: `--reporter=json` was inserted before the
   subcommand (e.g. `playwright --reporter=json test`), but Playwright
   requires flags after the subcommand (`playwright test --reporter=json`).

2. **Float duration deserialization**: `PlaywrightStats.duration` was typed
   as `u64`, but real Playwright output emits a float (e.g. `3519.703...`),
   causing serde_json to fail with a type error.

3. **Wrong suite structure**: Suites contain `specs` (not `tests`). Each
   spec has `ok: bool` and `tests` (per-browser executions). The old struct
   used `tests: Vec<PlaywrightTest>` directly in suites, which never matched
   real output and always failed JSON parsing.

Fixes:
- Move `--reporter=json` to after the first arg (the subcommand)
- Change `duration: u64` to `duration: f64` in `PlaywrightStats`
- Rewrite `PlaywrightSuite` → `specs: Vec<PlaywrightSpec>`
- Add `PlaywrightSpec` with `ok: bool` and `tests: Vec<PlaywrightExecution>`
- Add `PlaywrightExecution` with `status` and `results: Vec<PlaywrightAttempt>`
- Update `PlaywrightAttempt` to use `errors: Vec<PlaywrightError>` (array)
- Add tests covering float duration, real suite structure, and failure details

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@USerik USerik force-pushed the fix/playwright-json-parser branch from c963263 to 8f03e7e Compare February 25, 2026 07:23
heAdz0r added a commit to heAdz0r/rtk that referenced this pull request Feb 28, 2026
@heAdz0r @claude
release: fork.16 — backport 8 upstream PRs (rtk-ai#246, rtk-ai#193, r…
53472b0 
…tk-ai#217, rtk-ai#196, rtk-ai#248, rtk-ai#211, rtk-ai#200, rtk-ai#192, rtk-ai#268)

Wave 1 (critical bugs):
- fix(registry): fi/done moved to IGNORED_EXACT — find no longer shadowed (rtk-ai#246)
- fix(playwright): f64 duration, specs[] structure, --reporter=json after subcmd (rtk-ai#193)
- fix(gh): should_passthrough_gh_view for --json/--jq/--template/--web in view_pr/issue/run (rtk-ai#217+196)

Wave 2 (reliability):
- fix(git): is_blob_show_arg — blob show passthrough without trailing-newline trim (rtk-ai#248)
- fix(find): parse_find_args with native -name/-type/-maxdepth/-iname support (rtk-ai#211)
- fix(main): graceful Clap fallback + parse_failures SQLite table + rtk gain --failures (rtk-ai#200)

Wave 3 (UX):
- feat(git): global options -C/-c/--git-dir/--work-tree/--no-pager/--no-optional-locks/--bare/--literal-pathspecs (rtk-ai#192)
- feat(proxy): streaming output via spawn()+threads instead of buffered output() (rtk-ai#268)

Tests: 1091 → 1117 (+26), 0 regressions

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@pszymkowiak
Copy link
Copy Markdown
Collaborator

pszymkowiak commented Mar 2, 2026

Hi, this PR has conflicts with master in src/playwright_cmd.rs. Could you rebase on current master? Thanks!

@pszymkowiak
Copy link
Copy Markdown
Collaborator

pszymkowiak commented Mar 4, 2026

Reviewed and tested locally — 414 tests pass (5 playwright-specific), 0 clippy warnings. Clean merge with master.

All 3 bugs are real issues that made rtk playwright test unusable:

  1. ✅ --reporter=json position fixed (after subcommand)
  2. ✅ duration: f64 instead of u64
  3. ✅ Correct suite structure (specs → tests → results)

LGTM — ready to merge.

@pszymkowiak pszymkowiak merged commit 4eb6cf4 into rtk-ai:master Mar 4, 2026
@github-actions github-actions Bot mentioned this pull request Mar 4, 2026
Merged
@BrewTestBot BrewTestBot mentioned this pull request Mar 4, 2026
Merged
maxkulish added a commit to maxkulish/rtk that referenced this pull request Mar 18, 2026
@maxkulish
fix: port P1.3 other module fixes from upstream
bacd6c0 
Implements 6 bug fixes from upstream rtk-ai/rtk (v0.29.0):

P1.3a - playwright: JSON parser already matches real output format (rtk-ai#193)
- Already uses proper suites → specs → tests → results structure
- Handles float duration correctly (f64 type)
- No changes needed

P1.3b - cargo: `--` separator already preserved (rtk-ai#326)
- Already uses trailing_var_arg + allow_hyphen_values
- rtk cargo test -- --nocapture works correctly
- No changes needed

P1.3c - lint: strip npx/bunx/pnpm prefixes for linter detection (rtk-ai#186/rtk-ai#366)
- Add strip_pm_prefix() to remove package manager prefixes
- Add detect_linter() for accurate linter identification
- Fixes: npx eslint, bunx biome, pnpm exec eslint
- Tests: test_strip_pm_prefix(), test_detect_linter()

P1.3d - grep: BRE alternation translation already implemented (rtk-ai#206)
- Already translates \| (BRE) → | (PCRE) for rg
- Already strips -r flag (rg recursive by default)
- Comprehensive tests already exist
- No changes needed

P1.3e - filter: add Language::Data to prevent JSON/YAML/TOML corruption (rtk-ai#464/rtk-ai#479)
- Add Language::Data variant for data files
- Map 20 data file extensions (json, yaml, toml, xml, md, csv, etc.)
- Data language has NO comment patterns (all None)
- Fixes: packages/* in package.json no longer stripped as /* comment
- Tests: test_data_language_no_comment_stripping()

P1.3f - npm: fix routing to distinguish subcommands from scripts (rtk-ai#470)
- Add NPM_SUBCOMMANDS constant (59 known npm commands)
- Proper routing: npm install → npm install (not npm run install)
- Proper routing: npm build → npm run build (script)
- Tests: test_npm_subcommand_routing() validates all 59 subcommands

Files modified:
- src/lint_cmd.rs: Add PM prefix stripping
- src/filter.rs: Add Language::Data variant
- src/local_llm.rs: Add Language::Data match arm
- src/npm_cmd.rs: Add NPM_SUBCOMMANDS routing

Quality checks:
✅ cargo fmt --all
✅ cargo clippy --all-targets (0 errors)
✅ cargo test (514 passed; 0 failed)

Improves RTK reliability across JS/TS, data files, and npm workflows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting-changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@USerik @pszymkowiak @devkeruse