Skip to content

fix(gain): convert history timestamps from UTC to local timezone#562

Merged
FlorianBruniaux merged 1 commit intortk-ai:developfrom
yogasw:fix/gain-history-utc-to-local-time
Mar 28, 2026
Merged

fix(gain): convert history timestamps from UTC to local timezone#562
FlorianBruniaux merged 1 commit intortk-ai:developfrom
yogasw:fix/gain-history-utc-to-local-time

Conversation

@yogasw
Copy link
Copy Markdown
Contributor

@yogasw yogasw commented Mar 13, 2026

rtk gain --history displays timestamps in UTC, which is confusing for users in non-UTC timezones. For example, a command run at 17:09 WIB (UTC+7) would show as 03-13 10:09.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 20, 2026

CLA assistant check
All committers have signed the CLA.

@pszymkowiak
Copy link
Copy Markdown
Collaborator

Hi! Two things needed before we can review:

  1. Retarget to develop — this PR targets master, but all PRs should target develop. You can change the base branch in the PR settings (right sidebar).
  2. Sign the CLA — if not already done, please sign at https://cla-assistant.io/rtk-ai/rtk

Thanks!

@aeppling
Copy link
Copy Markdown
Contributor

Hey

We are cleaning up the codebase and improving the project structure for better onboarding. As part of this effort, PR #826 reorganizes src/ from a flat layout into subfolders.

No logic changes — only file moves and import path updates.

What you need to do

Rebase your branch on develop when receiving this comment:

git fetch origin && git rebase origin/develop

Git detects renames automatically. If you get import conflicts, update the paths:

use crate::git;        // now: use crate::cmds::git::git;
use crate::tracking;   // now: use crate::core::tracking;
use crate::config;     // now: use crate::core::config;
use crate::init;       // now: use crate::hooks::init;
use crate::gain;       // now: use crate::analytics::gain;

Need help rebasing? Tag @aeppling

@yogasw yogasw changed the base branch from master to develop March 27, 2026 07:13
@yogasw yogasw force-pushed the fix/gain-history-utc-to-local-time branch from 18f7e7b to 140e1f5 Compare March 27, 2026 07:44
@yogasw
Copy link
Copy Markdown
Contributor Author

yogasw commented Mar 27, 2026

Done! @pszymkowiak I've switched the base branch to develop and signed the CLA.

I also updated the path for the gain logic since src/gain.rs has moved to src/analytic/gain.rs. Thanks!

@FlorianBruniaux FlorianBruniaux merged commit da67c3e into rtk-ai:develop Mar 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants