Skip to content

fix: resolve clippy warnings in container, git, and init modules#583

Open
bz00qa wants to merge 1 commit intortk-ai:developfrom
bz00qa:fix/clippy-cleanup
Open

fix: resolve clippy warnings in container, git, and init modules#583
bz00qa wants to merge 1 commit intortk-ai:developfrom
bz00qa:fix/clippy-cleanup

Conversation

@bz00qa
Copy link
Copy Markdown

@bz00qa bz00qa commented Mar 13, 2026

Summary

Test plan

  • cargo clippy --all-targets passes
  • cargo test passes (937 passed, 2 pre-existing failures unrelated to these changes)
  • No behavioral changes — pure clippy cleanup

🤖 Generated with Claude Code

Apply clippy suggestions carved out from feature PRs rtk-ai#551 and rtk-ai#552:
- container.rs: .last() → .next_back() (2 instances)
- git.rs: .map_or(false, ...) → .is_some_and(...) (2 instances)
- git.rs: .last() → .next_back() (1 instance)
- init.rs: unnecessary format!() → .to_string() (1 instance)
- init.rs: unnecessary & on &str parameters (2 instances)

Signed-off-by: bZ00qa <167500396+bz00qa@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@aeppling
Copy link
Copy Markdown
Contributor

Hey

We are cleaning up the codebase and improving the project structure for better onboarding. As part of this effort, PR #826 reorganizes src/ from a flat layout into subfolders.

No logic changes — only file moves and import path updates.

What you need to do

Rebase your branch on develop when receiving this comment:

git fetch origin && git rebase origin/develop

Git detects renames automatically. If you get import conflicts, update the paths:

use crate::git;        // now: use crate::cmds::git::git;
use crate::tracking;   // now: use crate::core::tracking;
use crate::config;     // now: use crate::core::config;
use crate::init;       // now: use crate::hooks::init;
use crate::gain;       // now: use crate::analytics::gain;

Need help rebasing? Tag @aeppling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants