fix: git log --oneline regression drops commits#619
Merged
pszymkowiak merged 2 commits intodevelopfrom Mar 16, 2026
Merged
Conversation
When user passes --oneline, --pretty, or --format, RTK correctly skips injecting its custom format with ---END--- markers. However, filter_log_output() still tried to split on ---END---, treating the entire output as a single block and only preserving 2 lines. Add user_format parameter to filter_log_output: when true, use simple line-based truncation instead of ---END--- block splitting. Fixes regression introduced in PR #546 (commit c3416eb). Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu>
After the git log --oneline regression (PR #546), add a mandatory review step: trace all callers of modified functions and verify every input variant has a test. This prevents regressions where a function is changed but only one code path is tested. Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu>
maxkulish
added a commit
to maxkulish/rtk
that referenced
this pull request
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git log --oneline(and--pretty,--format) only returned 2 commits instead of the requested countfilter_log_output()always split on---END---markers, but those markers are only present when RTK injects its custom formatTest plan
rtk git log --oneline -5→ 5 commits (was 2 before fix)rtk git log --oneline -10→ 10 commitsrtk git log --pretty=format:"%h %s" -5→ 5 commitsrtk git log --format="%H" -3→ 3 commitsrtk git log -5→ 5 commits with RTK format (unchanged)