fix(cargo): preserve test compile diagnostics#738
Merged
aeppling merged 1 commit intortk-ai:developfrom Mar 20, 2026
Merged
Conversation
Signed-off-by: YoubAmj <11021965+youbamj@users.noreply.github.com>
Contributor
|
Hello, Thanks for this clean contribution ! For me this is explicit and straight-forward, we can merge this |
aeppling
approved these changes
Mar 20, 2026
aeppling
approved these changes
Mar 20, 2026
maxkulish
added a commit
to maxkulish/rtk
that referenced
this pull request
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo testfails before any test suites runcargo testoutput and relabel it fromcargo build:tocargo test:CHANGELOG.mdfor the cargo test compile-diagnostics fixTest plan
cargo fmt --all && cargo clippy --all-targets && cargo testsrc/cargo_cmd.rsfor compile-failingcargo testoutput./target/debug/rtk cargo test --test repro_compile_failerror[E0425]andtests/repro_compile_fail.rs:3:13Closes #740