fix: ls -R hierarchy + tracking baseline + incompatible flags (#714, #561)#799
fix: ls -R hierarchy + tracking baseline + incompatible flags (#714, #561)#799pszymkowiak wants to merge 1 commit intodevelopfrom
Conversation
…561) - ls -R: preserve directory hierarchy with indentation (files under their dir) - Tracking: compare against plain ls (not ls -la) for honest savings - Passthrough for flags incompatible with -l parser: -1, -d, -F, -i, -p Tested with 3 LLMs (llama, phi4, claude) on 20 ls variants: 100% comprehension. Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu>
📊 Automated PR Analysis
SummaryFixes recursive ls output to display directory hierarchy with indentation instead of flat listing, changes the tracking baseline to compare against plain ls rather than ls -la, and adds passthrough for flags incompatible with the -l parser (-1, -d, -F, -C, -m, -x, -i, -p). Review Checklist
Analyzed automatically by wshm · This is an automated analysis, not a human review. |
|
Hey We are cleaning up the codebase and improving the project structure for better onboarding. As part of this effort, PR #826 reorganizes No logic changes — only file moves and import path updates. What you need to doRebase your branch on git fetch origin && git rebase origin/developGit detects renames automatically. If you get import conflicts, update the paths: use crate::git; // now: use crate::cmds::git::git;
use crate::tracking; // now: use crate::core::tracking;
use crate::config; // now: use crate::core::config;
use crate::init; // now: use crate::hooks::init;
use crate::gain; // now: use crate::analytics::gain;Need help rebasing? Tag @aeppling |
|
I I believe this is a very necessary fix. Codex, in particular, has significant difficulties working without it, which in practice leads to increased token usage. |
…#714) - Recursive ls output now shows directory headers + indented children so the LLM can tell which files live in which directory. Previously every entry was collapsed into a flat list that lost all path information. - Incompatible flags (-1, -d, -F, -C, -m, -x, -i, -p) change ls output format enough that our `ls -la` parser breaks. Pass those through to raw ls so users still get the expected behavior. Supersedes #799 — ported to the new `runner::run_filtered` architecture. Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu>
|
Closing — superseded by #1251. This PR was based on the pre-refacto |
Closes #714, Closes #561
Changes
rtk ls -Rflattens recursive output and loses hierarchy context #714): recursive output now shows directory structure with indentationlsnotls -la#561): savings compared against plainls(notls -la)-1,-d,-F,-i,-ppassthrough to raw lsBefore/After
LLM comprehension test
20 ls variants tested with llama3.1:8b, phi4:14b, Claude — 100% comprehension on hierarchy.