feat: enable hook-based mode on Windows#809
Closed
MauroDeryckere wants to merge 1 commit intortk-ai:developfrom
Closed
feat: enable hook-based mode on Windows#809MauroDeryckere wants to merge 1 commit intortk-ai:developfrom
MauroDeryckere wants to merge 1 commit intortk-ai:developfrom
Conversation
Contributor
|
Hey We are cleaning up the codebase and improving the project structure for better onboarding. As part of this effort, PR #826 reorganizes No logic changes — only file moves and import path updates. What you need to doRebase your branch on git fetch origin && git rebase origin/developGit detects renames automatically. If you get import conflicts, update the paths: use crate::git; // now: use crate::cmds::git::git;
use crate::tracking; // now: use crate::core::tracking;
use crate::config; // now: use crate::core::config;
use crate::init; // now: use crate::hooks::init;
use crate::gain; // now: use crate::analytics::gain;Need help rebasing? Tag @aeppling |
ef01cb6 to
ebad5cc
Compare
aeppling
added a commit
that referenced
this pull request
Apr 19, 2026
Removing old guards, windows can now just use the binary hook engine from 0.37 Related issues: - Fixes #502 : rtk init --global falls back to --claude-md on Windows - Fixes #1353 : Feature request: hook-based mode on Windows - Partially addresses #330 : Add hooks support for Windows - Partially addresses #913 : Persistent "No hook installed" warning on Windows - Partially addresses #1373 : Suppress "No hook installed" warning on Windows - Partially addresses #682 : Config to suppress hook warning - Related to #1248 : Windows PowerShell compatibility gaps Supersedes community PRs: - #1123 fix(init): enable hook installation on Windows - #1027 fix(init): enable hook-based mode on Windows - #809 feat: enable hook-based mode on Windows - #452 feat: add Windows hook support for rtk init --global - #551 feat: native cross-platform hook for Windows support - #150 feat(hook): native cross-platform hook-rewrite command - #1063 Feat/windows hooks
Contributor
|
Hello, should be resolved in 0.37.2 |
Contributor
|
Thanks for this contribution , this has been implement in latest release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[cfg(not(unix))]fallbacks inrun_default_modeandrun_hook_only_modethat forced Windows into legacy CLAUDE.md injection modeensure_hook_installedcross-platform by wrapping only thechmodcall in#[cfg(unix)]rtk init -gand get the same hook-based setup as macOS/Linux (zero context cost, deterministic rewriting)Test plan
cargo fmt --all && cargo clippy --all-targets && cargo testrtk init -ghook script written and settings.json patched on Windows 11rtk rewrite "git status"returnsrtk git statuson Windows