fix: propagate exit code from rtk err and rtk test#939
Closed
niklasmarderx wants to merge 1 commit intortk-ai:masterfrom
Closed
fix: propagate exit code from rtk err and rtk test#939niklasmarderx wants to merge 1 commit intortk-ai:masterfrom
rtk err and rtk test#939niklasmarderx wants to merge 1 commit intortk-ai:masterfrom
Conversation
Both run_err and run_test returned Ok(()) regardless of the underlying command's exit status. This meant `rtk err false` exited 0 even though `false` returns 1. Now both call std::process::exit(exit_code) when the child process fails, matching the behavior of other RTK subcommands. Closes #846
|
|
Contributor
Author
|
Closing this — the Sorry for the noise with the base branch switch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rtk err falsereturned exit 0 even thoughfalsereturns 1. The error wasdetected and printed, but the process always exited successfully.
Same issue in
run_test.Fix
Both
run_errandrun_testnow callstd::process::exit(exit_code)whenthe child process fails, consistent with how other RTK subcommands propagate
exit codes.
Before / After
Closes #846