Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

Conversation

@nielstenboom
Copy link
Contributor

nodeSelectors were referenced in values.yaml but not used in the template files. Also some references were off.

Found this while adding the nodeSelectors internally 👍

spaghettifunk
spaghettifunk previously approved these changes Nov 3, 2020
Copy link
Contributor

@spaghettifunk spaghettifunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 🚀

@spaghettifunk spaghettifunk changed the base branch from master to development November 3, 2020 09:41
@spaghettifunk spaghettifunk changed the base branch from development to master November 3, 2020 09:41
@spaghettifunk spaghettifunk dismissed their stale review November 3, 2020 09:41

The base branch was changed.

@nielstenboom nielstenboom merged commit 69a4107 into master Nov 3, 2020
csimplestring added a commit that referenced this pull request Aug 3, 2021
* Development (#45)

* Update README.md

* Redis credentials (#44)

* Update issue templates

* OSS (#42)

* removing sensitive information for opensourcing the project

* add chart for deploying phoenix

* remove hardcoded port

* Update README.md

* Create docker-publish.yml

* Update README.md

* Update README.md

* Create LICENSE

* Update README.md

* Guidelines (#43)

* Create CODE_OF_CONDUCT.md

* Create CONTRIBUTING.md

* Update README.md

* Update README.md

* Create USERS.md

* Update README.md

* Update README.md

* bump redis client version, add DB_PASSWORD for redis password, fix worker queue

* typo in error checking

* add new ENV to chart

Co-authored-by: Niels ten Boom <nielstenboom@gmail.com>

* remove default password from tests and cli

Co-authored-by: Niels ten Boom <nielstenboom@gmail.com>

* Bugfix chart (#46)

* add missing nodeselectors + fixed wrong refs

* proper line endings

* bumbing up versions to remove vulnerabilites

* pinning alpine image to 3.13

Co-authored-by: Davide Berdin <davideberdin@gmail.com>
Co-authored-by: Niels ten Boom <nielstenboom@gmail.com>
Co-authored-by: Yi Wang <yi.wang@rtl.nl>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants