Consider moving from packr to pkger

[jufemaiz]

At the moment packr/v2 (https://github.com/gobuffalo/packr/tree/master/v2) is recommending people move to use http://github.com/markbates/pkger.

Perhaps this could be explored?

[rubenv]

Note that there isn't any packr dependency in sql-migrate, we just have a minimal interface that mimics the type, to avoid the run-time dependency.

I'm happy to accept a PR that adds a PkgrMigrationSource.

[rubenv]

But obviously, in the interest of backwards compatibility, we can't remove the PackrMigrationSource. Not a problem though, as it's just a small wrapper:

sql-migrate/migrate.go

Lines 334 to 389 in 64f95ea

	// Avoids pulling in the packr library for everyone, mimicks the bits of
	// packr.Box that we need.
	type PackrBox interface {
	List() []string
	Find(name string) ([]byte, error)
	}
	// Migrations from a packr box.
	type PackrMigrationSource struct {
	Box PackrBox
	// Path in the box to use.
	Dir string
	}
	var _ MigrationSource = (*PackrMigrationSource)(nil)
	func (p PackrMigrationSource) FindMigrations() ([]*Migration, error) {
	migrations := make([]*Migration, 0)
	items := p.Box.List()
	prefix := ""
	dir := path.Clean(p.Dir)
	if dir != "." {
	prefix = fmt.Sprintf("%s/", dir)
	}
	for _, item := range items {
	if !strings.HasPrefix(item, prefix) {
	continue
	}
	name := strings.TrimPrefix(item, prefix)
	if strings.Contains(name, "/") {
	continue
	}
	if strings.HasSuffix(name, ".sql") {
	file, err := p.Box.Find(item)
	if err != nil {
	return nil, err
	}
	migration, err := ParseMigration(name, bytes.NewReader(file))
	if err != nil {
	return nil, err
	}
	migrations = append(migrations, migration)
	}
	}
	// Make sure migrations are sorted
	sort.Sort(byId(migrations))
	return migrations, nil
	}

Shouldn't be hard to build the same thing for pkger.

[jufemaiz]

Sorry for the delayed response @rubenv (and thanks for a great package!). A little more investigation revealed that you've essentially already got the support able to be achieved (thanks in part to your solution, and the new pkger approach being adopted).

migDir := pkger.Dir("/db/migrations/")

migrations := &migrate.HttpFileSystemMigrationSource{
	FileSystem: migDir,
}

migrate.SetTable("migrations")
migrate.Exec(db, "postgres", migrations, migrate.Up)

[rubenv]

Ah that's great to hear. Perhaps we should add a small section to the README?

…

On Sun, Apr 5, 2020, 13:59 Joel Courtney ***@***.***> wrote: Sorry for the delayed response @rubenv <https://github.com/rubenv> (and thanks for a great package!). A little more investigation revealed that you've essentially already got the support able to be achieved (thanks in part to your solution, and the new pkger approach being adopted). migDir := pkger.Dir("/db/migrations/") migrations := &migrate.HttpFileSystemMigrationSource{ FileSystem: migDir, } migrate.SetTable("migrations") migrate.Exec(db, "postgres", migrations, migrate.Up) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#168 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAKPGFJBRXYGFEK3SYKRYDRLBXCHANCNFSM4LQA5JMA> .