Fix: getMigrationDbMap method incorrectly uses the global migration set#236
Closed
charithe wants to merge 1 commit intorubenv:masterfrom
Closed
Fix: getMigrationDbMap method incorrectly uses the global migration set#236charithe wants to merge 1 commit intorubenv:masterfrom
charithe wants to merge 1 commit intorubenv:masterfrom
Conversation
The `getMigrationDbMap` method on `MigrationSet` uses the global `migSet` to check whether table creation is disabled. It should be checking the instance variable instead. Signed-off-by: Charith Ellawala <charith.ellawala@gmail.com>
Contributor
Owner
|
#242 fixed this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
DisableTableCreateon aMigrationSethas no effect because thegetMigrationDbMapmethod onMigrationSetuses the globalmigSetinstead of the instance variable.Signed-off-by: Charith Ellawala charith.ellawala@gmail.com