Add context support to Exec methods#247
Merged
rubenv merged 2 commits intorubenv:masterfrom Jun 5, 2023
Merged
Conversation
Owner
|
Would have added context parameters in the first place if I were to start sql-migrate nowadays, but sadly it predates it. Adding them with extra methods feels consistent with the rest of the standard library. Also really like the added unit test. Good stuff! |
Contributor
Author
|
@rubenv sorry if this is the wrong place to ask, but what's the process to get a new version released with this PR? |
Owner
|
@sarajmunjal I just pushed version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR allows passing Go native context to Exec/ExecMax methods declared globally and on the
MigrationSetstruct.Why
Golang contexts are an elegant way to control program flow. With
Execmethods, contexts will enable timing out while running large migrations. In production, long-running DDL migration queries on large tables can obtain exclusive locks and cause downtime.Behavior can be seen in the newly added test
TestContextTimeout.